Skip to content

Refactoring of the RefactoryChange manager#16526

Merged
Ducasse merged 11 commits intopharo-project:Pharo13from
balsa-sarenac:refactor/refactory-change-manager
Apr 27, 2024
Merged

Refactoring of the RefactoryChange manager#16526
Ducasse merged 11 commits intopharo-project:Pharo13from
balsa-sarenac:refactor/refactory-change-manager

Conversation

@balsa-sarenac
Copy link
Member

@balsa-sarenac balsa-sarenac commented Apr 26, 2024

This PR introduces:

  • new API for the manager with deprecation of the old api
  • fixing previous behavior (changes could get lost if you were doing a bigger refactoring)

Now all changes in undo stack are composite, so no more partial undos.
New API is:

  • performChanges: with a list of changes to perform
  • performCompositeChange: with a composite change to perform
@request-info
Copy link

request-info bot commented Apr 26, 2024

This issue has either a default title or empty body. We would appreciate it if you could provide more information. Note: I am not a very intelligent bot, I can only react to new comments. Please add a comment for me if you update the body or title.

@jecisc
Copy link
Member

jecisc commented Apr 26, 2024

There is one failing test but I have the impression it is unrelated

@Ducasse Ducasse merged commit 039ecb5 into pharo-project:Pharo13 Apr 27, 2024
@balsa-sarenac balsa-sarenac deleted the refactor/refactory-change-manager branch April 27, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants