feat(smol): Add support for the smol runtime#21
Draft
felinira wants to merge 4 commits intopimalaya:masterfrom
Draft
feat(smol): Add support for the smol runtime#21felinira wants to merge 4 commits intopimalaya:masterfrom
felinira wants to merge 4 commits intopimalaya:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #19 and #20, please take a look at them first, they are much simpler to review :)
Also based on pimalaya/core#37
Adds support for the smol runtime as an option besides the tokio runtime.
There is still a lot of duplication going on here. I am quite sure it can be significantly reduced by completely pulling
Clientout of the tokio module (and renaming it, or the otherClient) and just having a few#[cfg(feature = "tokio")]in some places. Alternatively we could have traits that implement the extra functionality on top ofClient.