Skip to content

[Improvement]: Distribute queue into multiple workers in Supervisord conf#205

Merged
kingjia90 merged 1 commit into2024.3from
supervisord-asset-update
Nov 12, 2024
Merged

[Improvement]: Distribute queue into multiple workers in Supervisord conf#205
kingjia90 merged 1 commit into2024.3from
supervisord-asset-update

Conversation

@kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Nov 7, 2024

Resolves #150

By looking at pimcore/pimcore#16143 (comment) , it seems ideal to have a different worker for pimcore_asset_update

Notes:
The only queue that would "benefit" from being sequentially processed after previous queue is clear is pimcore_search_backend_message, after pimcore_scheduled_tasks, as the published/deleted state could change.
https://github.com/pimcore/pimcore/blob/3ffaeac8d9f07f877ea4f469015be1774de447b9/bundles/SimpleBackendSearchBundle/src/Model/Search/Backend/Data/Dao.php#L81 but in the skeleton the SimpleBackendSearchBundle is not enabled by default

@kingjia90

This comment was marked as resolved.

Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐺

@mattamon mattamon added this to the 2024.3.1 milestone Nov 8, 2024
@kingjia90 kingjia90 merged commit 7ce7de3 into 2024.3 Nov 12, 2024
@kingjia90 kingjia90 deleted the supervisord-asset-update branch November 12, 2024 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants