Accept block for link generator helper methods#153
Open
danschultzer wants to merge 2 commits intomainfrom
Open
Accept block for link generator helper methods#153danschultzer wants to merge 2 commits intomainfrom
danschultzer wants to merge 2 commits intomainfrom
Conversation
danschultzer force-pushed the pass-block-link-generator branch 2 times, most recently from 1eb5402 to cb791f3 Compare danschultzer force-pushed the pass-block-link-generator branch from cb791f3 to 3578932 Compare 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #151
Since do block runs before it's passed to the method there is no way of rewriting
PowAssent.Phoenix.ViewHelpers.provider_links/2. I don't know if this is the right approach. My general feeling is that this should be solved with pure CSS, or writing out the provider links logic manually.The view helpers provider very little extra functionality, so it might be best to just direct devs to write them out in their own view modules.