[currency converter] allow to deduce reverse rate#1126
Merged
SyntaxNode merged 1 commit intoprebid:masterfrom Dec 3, 2019
Merged
[currency converter] allow to deduce reverse rate#1126SyntaxNode merged 1 commit intoprebid:masterfrom
SyntaxNode merged 1 commit intoprebid:masterfrom
Conversation
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL allows the currency rate currency to deduce a currency rate even
if not directly defined in the table but the reverse rate is present.
E.q.
USD => EUR is 1.0897
EUR => USD is not set
Old behavior when asking rate from EUR to USD will not be found,
New behavior is using the known reverse rate to deduce the rate.
Rate for 2 USD will be 2 * (1 / 1.0897)