Beachfront Additional tests#1679
Merged
hhhjort merged 11 commits intoprebid:masterfrom Feb 11, 2021
beachfront:additional_tests
Merged
Beachfront Additional tests#1679hhhjort merged 11 commits intoprebid:masterfrom beachfront:additional_tests
hhhjort merged 11 commits intoprebid:masterfrom
beachfront:additional_tests
Conversation
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds most of the tests suggested by @bsardo on my last PR. I will add additional tests to improve coverage of default values when constructing a bid request in getBidRequest and getVideoRequests shortly, either incorporated into my multi imp AdM video PR or as a separate PR after that. These tests did find a couple of logical errors and I got those worked out.