Merged
Conversation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello PBS Team :)
This PR aims to plug Criteo's adapter. We still have couple things to test on our end but would love to have a review on this adapter in the meantime.
One question, we will be using
user.ext.eidsto retrieve Criteo's user ID. While testing locally, I was trying to get outgoing bid request to Criteo but somehow, I was never able to have anything populated inside PBSuser.ext.eids, I might miss something here, if you have any idea it would help me to do an end to end test.Here's the bid request I send to PBS:
Also, we would like to be off by default, and publishers we are already working / whiling to work with us would have to reach their Criteo point of contact. I guess this should be described in adapter's description on prebid documentation website, if so, I will edit the description and link it to this PR.
Cheers !