fix: handle empty string cookie values correctly#7128
Open
shindonghwi wants to merge 1 commit intopsf:mainfrom
Open
fix: handle empty string cookie values correctly#7128shindonghwi wants to merge 1 commit intopsf:mainfrom
shindonghwi wants to merge 1 commit intopsf:mainfrom
Conversation
_find_no_duplicates() was using 'if toReturn:' which treats empty string as falsy, causing KeyError when retrieving cookies with empty string values. Changed to 'if toReturn is not None:' to properly handle this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_find_no_duplicates()was checkingif toReturn:which treats empty string as falsy.This causes
KeyErrorwhen retrieving a cookie with an empty string value:Fixed by checking
if toReturn is not None:instead.Added test case.