Skip to content

Add Missing timeout#1489

Merged
JonnyWong16 merged 2 commits intopushingkarmaorg:masterfrom
chris-rudmin:patch-1
Dec 23, 2024
Merged

Add Missing timeout#1489
JonnyWong16 merged 2 commits intopushingkarmaorg:masterfrom
chris-rudmin:patch-1

Conversation

@chris-rudmin
Copy link
Contributor

@chris-rudmin chris-rudmin commented Dec 5, 2024

_timeout is expected on PlexClient

Description

Please include a summary of the change and which issue is fixed.

Fixes #1490

Type of change

Fix PlexSonosClient missing _timeout on self

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable
_timeout is expected on PlexClient
Add keyword arguments
@chris-rudmin
Copy link
Contributor Author

Test failures are on master branch and seem unrelated to my changes (tests/test_video.py::test_video_Movie_attrs[anonymously] ). All sonos tests are passing

@JonnyWong16 JonnyWong16 merged commit 0df73f5 into pushingkarmaorg:master Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants