Skip to content

pkg_resources: Wrong exception raised on parse error #2244

@lkollar

Description

@lkollar

Due to #2137 parse errors raise pkg_resources.extern.packaging.requirements.InvalidRequirement instead of packaging.requirements.InvalidRequirement.

I believe this is happening because pkg_resources imports the vendored packaging.requirements module.

Reproducer:

from pkg_resources import Requirement from packaging.requirements import InvalidRequirement from pkg_resources.extern.packaging.requirements import InvalidRequirement as ExternInvalidRequirement try: Requirement.parse(".") except InvalidRequirement as err: print(type(err)) except ExternInvalidRequirement as err: print(type(err))
$ python test.py <class 'pkg_resources.extern.packaging.requirements.InvalidRequirement'> 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions