Remove pkg_resources usage from installer (and more) #4997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… behavior with its explanation.
jaraco commented May 13, 2025
| pkg_resources.working_set.add(dist, replace=True) | ||
| # dist.locate_file('') is the directory containing EGG-INFO, where the importabl | ||
| # contents can be found. | ||
| sys.path.insert(0, str(dist.locate_file(''))) |
Member Author
There was a problem hiding this comment.
The biggest diff is in this change, which instead of relying of the pkg_resources.working_set, simply makes the package available on sys.path. There are probably some scenarios in which working_set provides more sophistication (possibly overriding already imported packages), but my instinct is that risk is low given the limited scope of setup_requires outside of pep517 these days.
cg505 reviewed May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of changes
Ref #3085
Pull Request Checklist
newsfragments/.(See documentation for details)