Skip to content

Add title and change spelling for use of approx with non-numerics #13343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

Add title and change spelling for use of approx with non-numerics #13343

merged 1 commit into from
Apr 3, 2025

Conversation

@callummscott
Copy link
Contributor

@callummscott callummscott commented Apr 2, 2025

Closes #13218.

  • Added title to draw attention to the easily-missed information on non-numeric types for approx.
  • Changed spelling of all cases of "nonnumeric" to "non-numeric" within docstrings for clarity and consistency with .rst files.
@nicoddemus nicoddemus added skip news used on prs to opt out of the changelog requirement backport 8.3.x labels Apr 3, 2025
nicoddemus
nicoddemus approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks better indeed! 👍
@nicoddemus nicoddemus merged commit 9a7dbd8 into pytest-dev:main Apr 3, 2025
28 checks passed
@patchback
Copy link

patchback bot commented Apr 3, 2025 •
edited
Loading

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/9a7dbd8a394bb47ee43be51d60ec3c4f4759789e/pr-13343

Backported as #13347

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.
patchback bot pushed a commit that referenced this pull request Apr 3, 2025
@callummscott @patchback
Add title and change spelling for use of approx with non-numerics (#1…
4f11440 
…3343) * Added title to draw attention to the easily-missed information on non-numeric types for approx. * Changed spelling of all cases of "nonnumeric" to "non-numeric" within docstrings for clarity and consistency with .rst files. Related to #13218 (cherry picked from commit 9a7dbd8)
@patchback patchback bot mentioned this pull request Apr 3, 2025
Merged
nicoddemus pushed a commit that referenced this pull request Apr 3, 2025
@patchback @callummscott
Add title and change spelling for use of approx with non-numerics (#1…
75cf3e7 
…3343) (#13347) * Added title to draw attention to the easily-missed information on non-numeric types for approx. * Changed spelling of all cases of "nonnumeric" to "non-numeric" within docstrings for clarity and consistency with .rst files. Related to #13218 (cherry picked from commit 9a7dbd8) Co-authored-by: Callum Scott <134177091+callummscott@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news used on prs to opt out of the changelog requirement

2 participants

@callummscott @nicoddemus