Skip to content

Use pytest.importorskip to skip on a missing import dependency#4436

Merged
radarhere merged 4 commits intopython-pillow:masterfrom
hugovk:pytest.importorskip
Feb 20, 2020
Merged

Use pytest.importorskip to skip on a missing import dependency#4436
radarhere merged 4 commits intopython-pillow:masterfrom
hugovk:pytest.importorskip

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Feb 18, 2020

For #4193.

Changes proposed in this pull request:

@hugovk hugovk added the Testing label Feb 18, 2020
@radarhere
Copy link
Member

Just so you're aware, this is an alternative to #4434

@hugovk
Copy link
Member Author

hugovk commented Feb 18, 2020

This actually covers something different to #4434: that skips tests when features are not available, this skips tests when imports are not possible :)

@hugovk
Copy link
Member Author

hugovk commented Feb 19, 2020

Ah, there was a bit of overlap for a bit of the WebP checking. Will update this to keep those as feature checking.

@python-pillow python-pillow deleted a comment from codecov bot Feb 19, 2020
Co-Authored-By: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@python-pillow python-pillow deleted a comment from codecov bot Feb 20, 2020
@radarhere radarhere merged commit f87505c into python-pillow:master Feb 20, 2020
@hugovk hugovk deleted the pytest.importorskip branch February 20, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants