Skip to content

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented May 1, 2023

From my microbenchmark, there was 4-5 % performance improvement.

Mean +- std dev: [base] 625 us +- 12 us -> [opt] 599 us +- 7 us: 1.04x faster 
@corona10 corona10 requested a review from kumaraditya303 May 1, 2023 05:11
@corona10 corona10 requested a review from pablogsal as a code owner May 1, 2023 05:11
@corona10 corona10 requested a review from Fidget-Spinner May 1, 2023 05:13
@corona10 corona10 changed the title gh-104028: Reduce objects creation while calling callback function on gc [WIP]gh-104028: Reduce objects creation while calling callback function on gc May 1, 2023
@corona10 corona10 changed the title [WIP]gh-104028: Reduce objects creation while calling callback function on gc gh-104028: Reduce objects creation while calling callback function on gc May 1, 2023
@corona10 corona10 changed the title gh-104028: Reduce objects creation while calling callback function on gc gh-104028: Reduce object creation while calling callback function on gc May 1, 2023
@corona10 corona10 changed the title gh-104028: Reduce object creation while calling callback function on gc gh-104028: Reduce object creation while calling callback function from gc May 1, 2023
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 enabled auto-merge (squash) May 1, 2023 13:38
@corona10 corona10 merged commit e147694 into python:main May 1, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
* main: (26 commits) pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030) pythongh-104036: Fix direct invocation of test_typing (python#104037) pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761) pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897) Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021) pythongh-88496: Fix IDLE test hang on macOS (python#104025) Improve int test coverage (python#104024) pythongh-88773: Added teleport method to Turtle library (python#103974) pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017) pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014) pythongh-103977: compile re expressions in platform.py only if required (python#103981) pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004) Replace Netlify with Read the Docs build previews (python#103843) Update name in acknowledgements and add mailmap (python#103696) pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927) Remove non-existing tools from Sundry skiplist (python#103991) pythongh-103793: Defer formatting task name (python#103767) pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933) pythongh-103636: issue warning for deprecated calendar constants (python#103833) Various small fixes to dis docs (python#103923) ...
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
* main: (463 commits) pythongh-104057: Fix direct invocation of test_super (python#104064) pythongh-87092: Expose assembler to unit tests (python#103988) pythongh-97696: asyncio eager tasks factory (python#102853) pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054) pythongh-104057: Fix direct invocation of test_module (pythonGH-104059) pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387) pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033) pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047) pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048) pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032) Fix typo in "expected" word in few source files (python#104034) pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993) pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041) pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030) pythongh-104036: Fix direct invocation of test_typing (python#104037) pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761) pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897) Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021) pythongh-88496: Fix IDLE test hang on macOS (python#104025) Improve int test coverage (python#104024) ...
@corona10 corona10 deleted the gh-104028 branch May 11, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants