gh-96471: Add threading queue shutdown #104225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @willingc ready for review |
EpicWink force-pushed the threading-queue-shutdown branch from fa1debe to ddeb9b6 Compare 
* Include docs
* Include raised exception in docstrings * Handle queue shutdown in task_done and join * Factor out queue-state checks and updates to methods * Logic fixes in qsize, get and shutdown * Don't set unfinished_tasks to 0 on immediate shutdown * Updated tests * Document feature added in 3.13
EpicWink force-pushed the threading-queue-shutdown branch from ddeb9b6 to 9c2971b Compare 
This was referenced May 6, 2023
EpicWink force-pushed the threading-queue-shutdown branch from ca118d7 to 089eb96 Compare 
Member
| Closing in favor of gh-104750. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Threading-only changes from #102499 (on top of #96474)
📚 Documentation preview 📚: https://cpython-previews--104225.org.readthedocs.build/