Skip to content

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 17, 2023

@terryjreedy terryjreedy added the 3.11 only security fixes label May 17, 2023
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of test additions, possible with change, and what to me are close to typo fixes. Both are routinely backported.

@terryjreedy terryjreedy added the needs backport to 3.11 only security fixes label May 17, 2023
@AlexWaygood
Copy link
Member

@terryjreedy, PEP 695 was only merged into main a few days ago; this PR can't be backported to 3.11

@AlexWaygood AlexWaygood added topic-typing and removed 3.11 only security fixes needs backport to 3.11 only security fixes labels May 17, 2023
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Does it make sense to add a cases with a function definition?
(test_syntax)

@JelleZijlstra JelleZijlstra merged commit 97db2f3 into python:main May 17, 2023
@JelleZijlstra JelleZijlstra deleted the main branch May 17, 2023 13:05
@JelleZijlstra JelleZijlstra restored the main branch May 17, 2023 13:05
@JelleZijlstra JelleZijlstra deleted the main branch May 17, 2023 13:05
@JelleZijlstra JelleZijlstra restored the main branch May 17, 2023 13:05
carljm added a commit to carljm/cpython that referenced this pull request May 17, 2023
* main: (26 commits) pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508) typing: Add more tests for TypeVar (python#104571) pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573) typing: Use PEP 695 syntax in typing.py (python#104553) pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508) pythongh-104469: Update README.txt for _testcapi (pythongh-104529) pythonGH-103092: isolate `_elementtree` (python#104561) pythongh-104050: Add typing to Argument Clinic converters (python#104547) pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909) pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351) pythonGH-103092: isolate `pyexpat` (python#104506) pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517) pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544) pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556) pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866) CODEOWNERS: Assign new PEP 695 files to myself (python#104551) pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) ...
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants