gh-105922: Add PyImport_AddModuleRef() function #105923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vstinner requested review from a team, brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners 
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
Nice; I left some comments.
Too bad we cannot run the ref leak bots now; there's already a ref leak in test_import and test_peg_generator that has not been resolved :(
Misc/NEWS.d/next/C API/2023-06-19-20-02-16.gh-issue-105922.o4T6wO.rst Outdated Show resolved Hide resolved
vstinner force-pushed the pyimport_addmoduleref branch from 631c02c to bf2a756 Compare 
Member Author
| I updated my PR:
|
erlend-aasland approved these changes Jun 19, 2023
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
Small typo nit. Otherwise looks good to me.
Misc/NEWS.d/next/C API/2023-06-19-20-02-16.gh-issue-105922.o4T6wO.rst Outdated Show resolved Hide resolved
* Add tests on PyImport_AddModuleRef(), PyImport_AddModule() and PyImport_AddModuleObject(). * pythonrun.c: Replace Py_XNewRef(PyImport_AddModule(name)) with PyImport_AddModuleRef(name).
Member Author
| I fixed the typo: similar than => similar to. |
vstinner force-pushed the pyimport_addmoduleref branch from 22c5f8c to f3a223d Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PyImport_AddModuleObject().
PyImport_AddModuleRef(name).
📚 Documentation preview 📚: https://cpython-previews--105923.org.readthedocs.build/