bpo-35479: Optimize multiprocessing.Pool.join() #11136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The multiprocessing.Pool.join() method now completes as soon as possible. Previously, it always had to wait at least 100 ms. multiprocessing.Pool._worker_handler() now waits on threading events rather than using naive time.sleep(0.1). When the pool is closed, a delay of 100 ms is still needed because of bpo-35478 bug (pending results never complete if the pool is terminated) to check if thread._state has been set to TERMINATE in the meanwhile.
Member Author
| test_pool_worker_lifetime() hangs with this change. My change doesn't work: self._worker_state_event isn't set when a worker completes, whereas _maintain_pool() should be called frequently to check when a worker completed. |
Member Author
| https://bugs.python.org/issue35479 and this PR have multiple issues, I close the PR. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The multiprocessing.Pool.join() method now completes as soon as
possible. Previously, it always had to wait at least 100 ms.
multiprocessing.Pool._worker_handler() now waits on threading events
rather than using naive time.sleep(0.1).
When the pool is closed, a delay of 100 ms is still needed because of
bpo-35478 bug (pending results never complete if the pool is
terminated) to check if thread._state has been set to TERMINATE in
the meanwhile.
https://bugs.python.org/issue35479