gh-113117: Support posix_spawn in subprocess.Popen with close_fds=True #113118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kulikjak requested review from corona10, erlend-aasland and gpshead as code owners 
kulikjak changed the title 
serhiy-storchaka approved these changes Dec 15, 2023
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
LGTM. Please add a NEWS and What's New entries.
gpshead approved these changes Dec 15, 2023
gpshead approved these changes Dec 17, 2023
gpshead added the 🔨 test-with-buildbots 
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot removed the 🔨 test-with-buildbots gpshead added the 🔨 test-with-buildbots bedevere-bot removed the 🔨 test-with-buildbots Gives a more useful description and mentions that it can be turned off but that we'd like to hear from anyone doing so.
(the joys of using the github web editor)
This describes the module changes in module sections and makes the Optimizations section brief, referring back up to the subprocess module.
gpshead added type-feature ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
…ds=True (python#113118) Add support for `os.POSIX_SPAWN_CLOSEFROM` and `posix_spawn_file_actions_addclosefrom_np` and have the `subprocess` module use them when available. This means `posix_spawn` can now be used in the default `close_fds=True` situation on many platforms. Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ds=True (python#113118) Add support for `os.POSIX_SPAWN_CLOSEFROM` and `posix_spawn_file_actions_addclosefrom_np` and have the `subprocess` module use them when available. This means `posix_spawn` can now be used in the default `close_fds=True` situation on many platforms. Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ds=True (python#113118) Add support for `os.POSIX_SPAWN_CLOSEFROM` and `posix_spawn_file_actions_addclosefrom_np` and have the `subprocess` module use them when available. This means `posix_spawn` can now be used in the default `close_fds=True` situation on many platforms. Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
Member
| I just discover this optimization by reading What's New in Python 3.13. Congrats @kulikjak, it's a great step forward! I didn't know that Linux supported this feature! |
Contributor Author
| ^^ Thanks! Though I am not sure how much Linux will benefit, considering it has vfork. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--113118.org.readthedocs.build/