gh-113119: Fix the macOS framework installer build #113268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gpshead changed the title 
Member Author
| Related: since this didn't come up in testing for the original change, it sounds like we're missing |
ned-deily approved these changes Dec 19, 2023
Member
ned-deily left a comment
ned-deily left a comment There was a problem hiding this comment.
LGTM, thanks for the quick fix.
Member Author
| I manually tested that building works on a mac with a configure --enable-framework - FWIW there appear to be a pile of tests that do not pass in framework builds regardless of this (looks environment related when launching python as a child process). |
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.