gh-116604: Correctly honor the gc status when calling _Py_RunGC #116628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Contributor
| Perfect, this looks good to me and solves the issue I encountered. For 3.12, the patch has to be adapted because the implementation of @pablogsal Besides 3.13, could this be pulled into the next Patch release of 3.12? |
Member Author
| Yup I will back port to 3.12 don't worry |
erlend-aasland approved these changes Mar 12, 2024
| Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
| Sorry, @pablogsal, I could not cleanly backport this to |
| GH-116653 is a backport of this pull request to the 3.12 branch. |
pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 12, 2024
…y_RunGC (pythonGH-116628) (cherry picked from commit 02918aa) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Mar 12, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PyGC_Disable()not respected #116604