bpo-36356: Release Unicode interned strings on Valgrind #12431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When Python is compiled with Valgrind support, release Unicode interned strings at exit in _PyUnicode_Fini(). * Rename _Py_ReleaseInternedUnicodeStrings() to unicode_release_interned() and make it private. * unicode_release_interned() is now called from _PyUnicode_Fini(): it must be called with a running Python thread state for TRASHCAN, it cannot be called from pymain_free(). * Don't display statistics on interned strings at exit anymore
Member Author
| @ericsnowcurrently: I'm not sure if interned strings are supposed to survive Py_Finalize(). I don't think so. Anyway, after Py_Finalize(), we cannot free interned strings anymore, since the code uses Py_TRASHCAN API which requires a valid Python thread state... but Py_Finalize() free all Python thread states! |
| @vstinner: Please replace |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When Python is compiled with Valgrind support, release Unicode
interned strings at exit in _PyUnicode_Fini().
unicode_release_interned() and make it private.
it must be called with a running Python thread state for TRASHCAN,
it cannot be called from pymain_free().
https://bugs.python.org/issue36356