Skip to content

bpo-23896: Add a grammar where exec isn't a stmt #13272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2019
Merged

bpo-23896: Add a grammar where exec isn't a stmt #13272

merged 2 commits into from
May 20, 2019

Conversation

@isidentical
Copy link
Member

@isidentical isidentical commented May 13, 2019 •
edited by bedevere-bot
Loading

Add a grammar where exec isn't a stmt

https://bugs.python.org/issue23896
@csabella csabella requested a review from benjaminp May 13, 2019 02:53
asottile
asottile approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, this is consistent with how yapf and others use this module for parsing py3 syntax
gvanrossum
gvanrossum reviewed May 20, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I guess this should be used by tools that are actually parsing Python 3... :-)
@gvanrossum gvanrossum merged commit 4011d86 into python:master May 20, 2019
@bedevere-bot
Copy link

bedevere-bot commented May 20, 2019

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
@isidentical isidentical deleted the bpo23896 branch December 7, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@isidentical @bedevere-bot @asottile @gvanrossum @auvipy @the-knights-who-say-ni