GH-139282: Support recursive wildcard in pathlib.PurePath.match() #139311
+25 −20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…h()` Add support for the recursive wildcard `**` in `pathlib.PurePath.match()`. This is a behaviour change for anyone currently calling `match()` with `**` in their pattern, but I reckon the vast majority of those users are expecting recursive matching and haven't realised that it's not working (: This brings `match()` behaviour closer to `full_match()`.
Contributor Author
| Is it worth putting this behind a new full argument? (I'm leaning towards "no", because there surely aren't many users who employ |
Contributor Author
| Hi Steve, I've tagged you for review as you helped with #114350, hope that's alright. Thanks :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add support for the recursive wildcard
**inpathlib.PurePath.match(). This is a behaviour change for anyone currently callingmatch()with**in their pattern, but I reckon the vast majority of those users are expecting recursive matching and haven't realised that it's not working (:This brings
match()behaviour closer tofull_match().pathlib.PurePath.match()andfull_match()#139282📚 Documentation preview 📚: https://cpython-previews--139311.org.readthedocs.build/