Skip to content

bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock #14117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock #14117

wants to merge 2 commits into from

Conversation

@tirkarthi
Copy link
Member

@tirkarthi tirkarthi commented Jun 15, 2019 •
edited by bedevere-bot
Loading

MagicMock with a function spec will have __code__ object. When it is used a spec to mock.patch then __code__ object which is a MagicMock is used to detect if it's a coroutine. MagicMock.__code__ & 128 returns another MagicMock which is evaluated to True and returned as a coroutine incorrectly. Hence check __code__ to be a CodeType to make sure MagicMock with __code__ is not detected as coroutine.

https://bugs.python.org/issue37251
@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Jun 21, 2019
lisroach referenced this pull request in lisroach/cpython Sep 9, 2019
@lisroach
Fixes _is_async_obj removing __code__ check.
903ff5a
@tirkarthi
Copy link
Member Author

tirkarthi commented Sep 11, 2019

Closing in favor of #15830 .
@tirkarthi tirkarthi closed this Sep 11, 2019
@jeremycline jeremycline mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review type-bug An unexpected behavior, bug, or error

5 participants

@tirkarthi @mangrisano @brettcannon @the-knights-who-say-ni @bedevere-bot