Skip to content

bpo-35696: Remove unnecessary operation in long_compare() #16146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2019
Merged

bpo-35696: Remove unnecessary operation in long_compare() #16146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8b5f0b
improve perfomance of long_compare
hongweipeng Sep 14, 2019
99858bf
C code requires braces
hongweipeng Sep 15, 2019
5dc0e85
rewrite long_compare
hongweipeng Sep 17, 2019
da73290
code review
hongweipeng Sep 17, 2019
8996ee5
remove news
hongweipeng Sep 18, 2019
2fb6856
code review
hongweipeng Sep 18, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2019-09-15-01-30-06.bpo-35696.1iK_1H.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Slightly improve perfomance of long_compare. Patch by hongweipeng.
14 changes: 5 additions & 9 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3038,17 +3038,13 @@ long_compare(PyLongObject *a, PyLongObject *b)
}
else {
Py_ssize_t i = Py_ABS(Py_SIZE(a));
while (--i >= 0 && a->ob_digit[i] == b->ob_digit[i])
while (--i > 0 && a->ob_digit[i] == b->ob_digit[i])
;
if (i < 0)
sign = 0;
else {
sign = (sdigit)a->ob_digit[i] - (sdigit)b->ob_digit[i];
if (Py_SIZE(a) < 0)
sign = -sign;
}
sign = (sdigit)a->ob_digit[i] - (sdigit)b->ob_digit[i];
if (Py_SIZE(a) < 0)
sign = -sign;
}
return sign < 0 ? -1 : sign > 0 ? 1 : 0;
return sign;
}

static PyObject *
Expand Down