bpo-40744: Drop support for SQLite pre 3.7.3 #20909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove code required to to support SQLite pre 3.7.3. Integrate setup.py, docs and unit test changes from PR python#17413 Style changes not related to bpo-40744 were dropped from the merge. Berker Peksag's suggested documentation changes was included. See python#17413 Co-written-by: Berker Peksag <berker.peksag@gmail.com> Co-written-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
erlend-aasland force-pushed the fix-issue-40744 branch from 0782d45 to 22fb16b Compare 
Contributor Author
| @pablogsal, would you mind if I request your review on this as well? |
Member
No problem. Will try to give it a go soon. Feel free to ping me in a couple of days if I have not made a review by then :) |
pablogsal reviewed Sep 7, 2020
Misc/NEWS.d/next/Library/2020-05-30-08-10-23.bpo-40744.jKURVV.rst Outdated Show resolved Hide resolved
pablogsal added the 🔨 test-with-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 22fb16b 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots pablogsal reviewed Sep 7, 2020
pablogsal approved these changes Sep 7, 2020
Contributor Author
| Thanks for the review, @pablogsal ! |
Member
| Thanks, @erlend-aasland for the PR :) |
Contributor Author
| Should this be backported to 3.9, or is it too late? |
Member
Too late IMHO, check my message on bpo |
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
* origin/master: (1373 commits) bpo-1635741: Port mashal module to multi-phase init (python#22149) bpo-1635741: Port _string module to multi-phase init (pythonGH-22148) bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134) bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139) bpo-41732: add iterator to memoryview (pythonGH-22119) bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909) bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511) bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092) bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986) bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051) bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050) bpo-1635741 port zlib module to multi-phase init (pythonGH-21995) [doc] Add link to Generic in typing (pythonGH-22125) bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123) bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818) closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110) [doc] Fix padding in some typing definitions (pythonGH-22114) Fix documented Python version for venv --upgrade-deps (pythonGH-22113) bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581) bpo-41687: Fix sendfile implementation to work with Solaris (python#22040) ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Remove code required to support SQLite pre 3.7.3. Co-written-by: Berker Peksag <berker.peksag@gmail.com> Co-written-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove code required to to support SQLite pre 3.7.3.
Integrate setup.py, docs and unit test changes from PR #17413
Style changes not related to bpo-40744 were dropped from the merge.
Berker Peksag's suggested documentation changes was included.
See #17413
Co-written-by: Berker Peksag berker.peksag@gmail.com
Co-written-by: Sergey Fedoseev fedoseev.sergey@gmail.com
https://bugs.python.org/issue40744