Skip to content

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Jan 27, 2022

This reverts commit b0a6ede.

We're deferring this change until 3.12 while upstream projects that use
the legacy assertion method names are fixed. See the issue for links
to the discussion.

https://bugs.python.org/issue45162

…onGH-28268)" This reverts commit b0a6ede. We're deferring this change until 3.12 while upstream projects that use the legacy assertion method names are fixed. See the issue for links to the discussion.
@gpshead gpshead requested a review from vstinner January 27, 2022 00:01
@vstinner
Copy link
Member

I don't understand the Docs CI failure:

PATH=./venv/bin:$PATH sphinx-build -b doctest -d build/doctrees -q -W --keep-going -j4 -W . build/doctest ... make[1]: *** [Makefile:51: build] Error 1 make[1]: Leaving directory '/home/runner/work/cpython/cpython/Doc' Testing of doctests in the sources finished, look at the results in build/doctest/output.txt make: *** [Makefile:131: doctest] Error 1 make: Leaving directory '/home/runner/work/cpython/cpython/Doc' Error: Process completed with exit code 2. 
@vstinner
Copy link
Member

Ah, maybe the warning is treated as an error:

Warning: ../build/NEWS:83: WARNING: Unknown interpreted text role "module". 
@vstinner
Copy link
Member

I guess that the change is related to this python-dev discussion:
https://mail.python.org/archives/list/python-dev@python.org/thread/GJTREADEXYAETECE5JDTPYWK4WMTKYGR/

Co-authored-by: Victor Stinner <vstinner@python.org>
@gpshead gpshead merged commit b50322d into python:main Jan 27, 2022
@gpshead gpshead deleted the defer-bpo45162-to-312 branch January 27, 2022 04:39
@bedevere-bot
Copy link

bedevere-bot commented Jan 27, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 C9S 3.x has failed when building commit b50322d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/791/builds/4) and take a look at the build logs.
  4. Check if the failure is related to this commit (b50322d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/791/builds/4

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 21, done.  remote: Counting objects: 4% (1/21)  remote: Counting objects: 9% (2/21)  remote: Counting objects: 14% (3/21)  remote: Counting objects: 19% (4/21)  remote: Counting objects: 23% (5/21)  remote: Counting objects: 28% (6/21)  remote: Counting objects: 33% (7/21)  remote: Counting objects: 38% (8/21)  remote: Counting objects: 42% (9/21)  remote: Counting objects: 47% (10/21)  remote: Counting objects: 52% (11/21)  remote: Counting objects: 57% (12/21)  remote: Counting objects: 61% (13/21)  remote: Counting objects: 66% (14/21)  remote: Counting objects: 71% (15/21)  remote: Counting objects: 76% (16/21)  remote: Counting objects: 80% (17/21)  remote: Counting objects: 85% (18/21)  remote: Counting objects: 90% (19/21)  remote: Counting objects: 95% (20/21)  remote: Counting objects: 100% (21/21)  remote: Counting objects: 100% (21/21), done.  remote: Compressing objects: 10% (1/10)  remote: Compressing objects: 20% (2/10)  remote: Compressing objects: 30% (3/10)  remote: Compressing objects: 40% (4/10)  remote: Compressing objects: 50% (5/10)  remote: Compressing objects: 60% (6/10)  remote: Compressing objects: 70% (7/10)  remote: Compressing objects: 80% (8/10)  remote: Compressing objects: 90% (9/10)  remote: Compressing objects: 100% (10/10)  remote: Compressing objects: 100% (10/10), done.  remote: Total 21 (delta 11), reused 11 (delta 11), pack-reused 0  From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: switching to 'b50322d20337ca468f2070eedb051a16ee1eba94'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at b50322d203 [bpo-45162](https://bugs.python.org/issue45162): Revert "Remove many old deprecated unittest features" (GH-30935) Switched to and reset branch 'main' In file included from ../Modules/expat/xmltok.c:57: ../Modules/expat/xmltok_ns.c: In function ‘findEncoding’: ../Modules/expat/xmltok.h:276:10: warning: ‘buf’ may be used uninitialized [-Wmaybe-uninitialized] 276 | (((enc)->utf8Convert)(enc, fromP, fromLim, toP, toLim)) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../Modules/expat/xmltok.h:276:10: note: by argument 5 of type ‘const char *’ to ‘XML_Convert_Result <T6d3> (const struct ENCODING *, const char * *, const char *, char * *, const char *)’ In file included from ../Modules/expat/xmltok.c:1654: ../Modules/expat/xmltok_ns.c:96:8: note: ‘buf’ declared here 96 | char buf[ENCODING_MAX]; | ^~~ In file included from ../Modules/expat/xmltok.c:57: ../Modules/expat/xmltok_ns.c: In function ‘findEncodingNS’: ../Modules/expat/xmltok.h:276:10: warning: ‘buf’ may be used uninitialized [-Wmaybe-uninitialized] 276 | (((enc)->utf8Convert)(enc, fromP, fromLim, toP, toLim)) | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../Modules/expat/xmltok.h:276:10: note: by argument 5 of type ‘const char *’ to ‘XML_Convert_Result <T6d3> (const struct ENCODING *, const char * *, const char *, char * *, const char *)’ In file included from ../Modules/expat/xmltok.c:1665: ../Modules/expat/xmltok_ns.c:96:8: note: ‘buf’ declared here 96 | char buf[ENCODING_MAX]; | ^~~ lto1: fatal error: error writing to /tmp/ccY9JaSx.s: No space left on device compilation terminated. lto-wrapper: fatal error: gcc returned 1 exit status compilation terminated. /usr/bin/ld: error: lto-wrapper failed collect2: error: ld returned 1 exit status make: *** [Makefile:1170: Programs/_freeze_module] Error 1 find: ‘build’: No such file or directory find: ‘build’: No such file or directory find: ‘build’: No such file or directory find: ‘build’: No such file or directory make: [Makefile:2464: clean-retain-profile] Error 1 (ignored)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants