bpo-43292: Fix file leak in ET.iterparse() when not exhausted #31696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
What if pass a path of non-existing file to iterparse(),
serhiy-storchaka approved these changes Mar 6, 2022
serhiy-storchaka added needs backport to 3.9 needs backport to 3.10 
Contributor
| Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
| Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 7, 2022
…onGH-31696) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 496c428) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
| GH-31720 is a backport of this pull request to the 3.9 branch. |
bedevere-bot removed needs backport to 3.9 needs backport to 3.10 | GH-31721 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 7, 2022
…onGH-31696) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 496c428) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…pythonGH-31696) (pythonGH-31720) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 496c428) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
bpo-43292: This fixes the file leak in
xml.etree.ElementTree.iterparsewhen the iterator is garbage collected before being exhausted.Regression test fails on main.
Related, but not done in this PR: bpo-25707 is a request for an explicit
close()method foriterparse(). I am not certain if that feature would still be desired after this change.https://bugs.python.org/issue43292