bpo-28298: make array 'Q', 'L' and 'I' accept big intables as elements #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @orenmn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @serhiy-storchaka, @vadmium, @doerwalter and @Yhg1s to be potential reviewers. |
serhiy-storchaka added type-bug Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
Add an entry in Misc/NEWS.
Modules/arraymodule.c Outdated
| (unsigned long) ((unsigned int *)ap->ob_item)[i]); | ||
| } | ||
| | ||
| static int |
Member
There was a problem hiding this comment.
I would just return PyObject * (NULL if error). This simplifies the code and perhaps makes easier changing it for using __index__.
serhiy-storchaka approved these changes Mar 9, 2017
serhiy-storchaka added a commit that referenced this pull request Mar 9, 2017
Member
| Oh, I reverted just merged commit! How to restore it back? |
Member
| It was not merged into master. Don't worry. |
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.7.1...1.7.2) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
according to http://bugs.python.org/issue28298:
__int__) as elementslong longis available(I ran the test module again, and on my Windows 10, the same tests failed with
and without my patches. However, on my Ubuntu 16.04 VM, none of the tests
failed.)