Skip to content

Use assertEqual() instead of assertEquals(). #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2018
Merged

Use assertEqual() instead of assertEquals(). #9721

merged 1 commit into from
Oct 5, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 5, 2018 •
edited by bedevere-bot
Loading

Fixes warnings in tests added in bpo-32117 and bpo-34603.
@serhiy-storchaka
Use assertEqual() instead of assertEquals().
2b2586c 
Fixes warnings in tests added in bpo-32117 and bpo-34603.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Oct 5, 2018
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 5, 2018
Closed
@serhiy-storchaka serhiy-storchaka merged commit 4642d5f into python:master Oct 5, 2018
@serhiy-storchaka serhiy-storchaka deleted the tests-assertEquals branch October 5, 2018 18:10
@miss-islington
Copy link
Contributor

miss-islington commented Oct 5, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
@miss-islington
Copy link
Contributor

miss-islington commented Oct 5, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4642d5f59828e774585e9895b538b24d71b9df8e 3.7
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 5, 2018
@serhiy-storchaka
Use assertEqual() instead of assertEquals(). (pythonGH-9721)
a57c655 
Fixes warnings in test added in bpo-34603. (cherry picked from commit 4642d5f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 5, 2018

GH-9725 is a backport of this pull request to the 3.7 branch.
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 5, 2018
serhiy-storchaka added a commit that referenced this pull request Oct 5, 2018
@serhiy-storchaka
Use assertEqual() instead of assertEquals(). (GH-9721) (GH-9725)
6bffe50 
Fixes warnings in test added in bpo-34603. (cherry picked from commit 4642d5f)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2018
@serhiy-storchaka @miss-islington
Use assertEqual() instead of assertEquals(). (pythonGH-9721) (pythonG…
1ac1a95 
…H-9725) Fixes warnings in test added in bpo-34603. (cherry picked from commit 4642d5f) (cherry picked from commit 6bffe50) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Oct 5, 2018
@miss-islington @serhiy-storchaka
Use assertEqual() instead of assertEquals(). (GH-9721) (GH-9725) (GH-…
d02490a 
…9727) Fixes warnings in test added in bpo-34603. (cherry picked from commit 4642d5f) (cherry picked from commit 6bffe50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni