Skip to content

Conversation

@carljm
Copy link
Member

@carljm carljm commented Oct 7, 2022

This API should have been in #31787 but we forgot about it.

Also clean up some minor things: add to whatsnew, add versionadded tags, use test.support.catch_unraisable_exceptions instead of reinventing it.

@carljm
Copy link
Member Author

carljm commented Oct 7, 2022

Added "skip news" label since this is already covered by the NEWS entry from #31787.

@markshannon
Copy link
Member

I don't know what the docs failure is, but everything else looks good.

@JelleZijlstra
Copy link
Member

The docs failure is unrelated, #98056 will fix it.

@JelleZijlstra JelleZijlstra self-assigned this Oct 7, 2022
@JelleZijlstra JelleZijlstra merged commit e82d977 into python:main Oct 8, 2022
@carljm carljm deleted the dictunwatch branch October 8, 2022 00:38
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
* main: pythongh-68686: Retire eptag ptag scripts (python#98064) pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079) pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914) pythongh-97822: Fix http.server documentation reference to test() function (python#98027) pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055) pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024) pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
carljm added a commit to carljm/cpython that referenced this pull request Oct 9, 2022
* main: (5519 commits) Minor edits to the Descriptor HowTo Guide (pythonGH-24901) Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102) pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers (python#98089) Auto-cancel old builds when new commit pushed to branch (python#98009) pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012) pythongh-68686: Retire eptag ptag scripts (python#98064) pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079) pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914) pythongh-97822: Fix http.server documentation reference to test() function (python#98027) pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055) pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024) pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184) pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058) pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060) pythongh-57179: Add note on symlinks for os.walk (python#94799) pythongh-94808: Fix regex on exotic platforms (python#98036) pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) ...
@vstinner
Copy link
Member

Thanks for adding .. versionadded:: 3.12 and documenting the new functions in What's New. The test looks better with catch_unraisable_exception.

mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants