Skip to content

[CLEAN] Synthetic Benchmark PR #30444 - chore: integrate @tanstack/eslint-plugin-query and fix service layer lint errors#262

Open
tomerqodo wants to merge 1 commit intobase_pr_30444_20260114_3823from
clean_pr_30444_20260114_3823
Open

[CLEAN] Synthetic Benchmark PR #30444 - chore: integrate @tanstack/eslint-plugin-query and fix service layer lint errors#262
tomerqodo wants to merge 1 commit intobase_pr_30444_20260114_3823from
clean_pr_30444_20260114_3823

Conversation

@tomerqodo
Copy link

Benchmark PR langgenius#30444

Type: Clean (correct implementation)

Original PR Title: chore: integrate @tanstack/eslint-plugin-query and fix service layer lint errors
Original PR Description: ## Summary
This PR integrates @tanstack/eslint-plugin-query to improve code quality and reliability by enforcing React Query best practices. It also resolves multiple exhaustive-deps violations identified in the service/ directory.

Changes

  • Dependency: Added @tanstack/eslint-plugin-query as a dev dependency.
  • Configuration: Updated eslint.config.mjs to enable the flat/recommended rule set.
  • Refactoring: Fixed missing dependencies in queryKey across multiple service hooks to ensure data freshness and correct caching behavior.

Fix Details

Fixed exhaustive-deps errors in the following files by ensuring all external variables used in queryFn are included in the queryKey:

  • service/use-apps.ts
  • service/use-explore.ts
  • service/use-models.ts
  • service/use-pipeline.ts
  • service/use-plugins.ts
  • service/knowledge/use-segment.ts
  • service/access-control.ts
  • service/knowledge/use-document.ts
  • app/components/goto-anything/index.tsx

Related Issue

Closes langgenius#30443
Original PR URL: langgenius#30444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant