Skip to content

[CLEAN] Synthetic Benchmark PR #30617 - refactor: restructure DatasetCard component for improved readability and maintainability#362

Open
ofir-frd wants to merge 1 commit intobase_pr_30617_20260120_6648from
clean_pr_30617_20260120_6648
Open

[CLEAN] Synthetic Benchmark PR #30617 - refactor: restructure DatasetCard component for improved readability and maintainability#362
ofir-frd wants to merge 1 commit intobase_pr_30617_20260120_6648from
clean_pr_30617_20260120_6648

Conversation

@ofir-frd
Copy link

Benchmark PR langgenius#30617

Type: Clean (correct implementation)

Original PR Title: refactor: restructure DatasetCard component for improved readability and maintainability
Original PR Description: ## Summary

refactor: restructure DatasetCard component for improved readability and maintainability

  • Split DatasetCard into multiple subcomponents: CornerLabels, DatasetCardHeader, DatasetCardFooter, DatasetCardModals, Description, TagArea, and OperationsPopover.
  • Introduced a custom hook, useDatasetCardState, to manage state and modal logic.
  • Enhanced tag management and modal handling for renaming and deletion.
  • Improved code organization and reduced complexity in the main DatasetCard component.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Original PR URL: langgenius#30617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant