[CLEAN] Synthetic Benchmark PR #30333 - fix(api): surface subscription deletion errors to users#364
Open
ofir-frd wants to merge 1 commit intobase_pr_30333_20260120_2230from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR langgenius#30333
Type: Clean (correct implementation)
Original PR Title: fix(api): surface subscription deletion errors to users
Original PR Description: ## Summary
This PR fixes a bug where trigger subscription deletion/unsubscribe errors were silently ignored during the rebuild process.
UnsubscribeResult.successand propagate error messages to users when unsubscribe failsany()Fixes langgenius#30332
Test Plan
Original PR URL: fix(api): surface subscription deletion errors to users langgenius/dify#30333