Ensure client WebSocket connection can always be made #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is needed because WebsocketConnectionBuilder might be configured with a non NioEventLoopGroup Relates to: quarkusio/quarkus#41082
Status for workflow |
| Status | Name | Step | Failures | Logs | Raw logs |
|---|---|---|---|---|---|
| ✔️ | Build - JDK 11 | Logs | Raw logs | ||
| ✖ | Build - JDK 17 | Build with Maven | Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
Failures
⚙️ Build - JDK 17 #
- Failing: servlet ! Skipped: websocket websocket/core websocket/servlet and 1 more📦 servlet
✖ io.undertow.servlet.test.dispatcher.DispatcherForwardTestCase.testPathBasedInclude line 137 - More details - Source on GitHub
org.junit.ComparisonFailure: expected:<...etContext/dispatch /[dispatch]> but was:<...etContext/dispatch /[forward]> at org.junit.Assert.assertEquals(Assert.java:117) at org.junit.Assert.assertEquals(Assert.java:146) at io.undertow.servlet.test.dispatcher.DispatcherForwardTestCase.testPathBasedInclude(DispatcherForwardTestCase.java:137) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) 
Contributor Author
| I am pretty sure the test failure has nothing to do with this change |
cescoffier reviewed Jun 10, 2024
| return eventLoopGroup; | ||
| } | ||
| // there is not much else we can do here... | ||
| return new NioEventLoopGroup(); |
Member
There was a problem hiding this comment.
I agree, but it's unfortunate. We should add a note in the Quarkus documentation when using the legacy web socket implementation; native transport is not recommended.
cescoffier approved these changes Jun 10, 2024
Contributor Author
| I have verified that the CI failure is present in |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is needed because WebsocketConnectionBuilder might be configured with a non NioEventLoopGroup
Relates to: quarkusio/quarkus#41082