Skip to content

Conversation

@Balastrong
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

I noticed the RatingIcon component did not have any key property (this was also logged in console)

2:54:54 PM [vite] page reload /Users/leonardo/PersProgetti/qwik-ui/packages/headless/src/components/rating/rating.tsx QWIK ERROR JSXError: Multiple JSX sibling nodes with the same key. This is likely caused by missing a custom key in a for loop at eval (/src/rating_component_qsamuiuvsow.js:45:56) at Array.map (<anonymous>) at Rating_component_QSAMuIUvsOw (/src/rating_component_qsamuiuvsow.js:43:45) at async Promise.all (index 0) at async Promise.all (index 1) at async Promise.all (index 1) at async Promise.all (index 1) at async Promise.all (index 1) at async Promise.all (index 1) at async Promise.all (index 0) 

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Balastrong
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@gioboa
Copy link
Contributor

gioboa commented Feb 18, 2023

Thanks for your help 😄

@gioboa
Copy link
Contributor

gioboa commented Feb 18, 2023

@all-contributors please add @Balastrong for code, bug

@allcontributors
Copy link
Contributor

@gioboa

I've put up a pull request to add @Balastrong! 🎉

@gioboa gioboa merged commit b9f47b1 into qwikifiers:main Feb 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2023
@Balastrong Balastrong deleted the bug/rating-key branch February 18, 2023 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants