snapshotOfLastVideoBuffer was not working#309
Open
GabeRoze wants to merge 58 commits intorFlex:masterfrom
Open
snapshotOfLastVideoBuffer was not working#309GabeRoze wants to merge 58 commits intorFlex:masterfrom
GabeRoze wants to merge 58 commits intorFlex:masterfrom
Conversation
| lol small world |
Author
| hah fancy meeting you here. Ever figure out what was wrong with your AVPlayer? |
| Not yet, I took a break from it. Had some more people reach out to help, some promising leads. I may just move to paging. |
Owner
| Hey, that's a great fix. Could you please refactor your change on mergeSegmentsUsingPreset so the code is not duplicated? You could make the original implementation figure out the outputUrl and call |
Owner
| Also, it's a small detail but on the header you should add the specifiers to tell if an argument is optional or not. That way it integrates nicely with Swift :). Thank you so much! |
| Quick fix until pull request is open: |
# Conflicts: # Library/Sources/SCAssetExportSession.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIContext was nil, now its not.