Skip to content

snapshotOfLastVideoBuffer was not working#309

Open
GabeRoze wants to merge 58 commits intorFlex:masterfrom
bsmash:master
Open

snapshotOfLastVideoBuffer was not working#309
GabeRoze wants to merge 58 commits intorFlex:masterfrom
bsmash:master

Conversation

@GabeRoze
Copy link

CIContext was nil, now its not.

@mitchellporter
Copy link

lol small world

@GabeRoze
Copy link
Author

hah fancy meeting you here. Ever figure out what was wrong with your AVPlayer?

@mitchellporter
Copy link

Not yet, I took a break from it. Had some more people reach out to help, some promising leads. I may just move to paging.

@rFlex
Copy link
Owner

rFlex commented May 18, 2016

Hey, that's a great fix. Could you please refactor your change on mergeSegmentsUsingPreset so the code is not duplicated? You could make the original implementation figure out the outputUrl and call [self mergeSegmentsUsingPreset:preset atURL:outputUrl completion:completion]

@rFlex
Copy link
Owner

rFlex commented May 18, 2016

Also, it's a small detail but on the header you should add the specifiers to tell if an argument is optional or not. That way it integrates nicely with Swift :). Thank you so much!

@AlexandrGraschenkov
Copy link

Quick fix until pull request is open:

 let recorder = SCRecorder.shared() let context = SCContext(type: .auto) recorder.setValue(context.ciContext, forKeyPath: "_context") 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants