Merged
Conversation
633b909 to 5098413 Compare Merged
lukebakken added a commit that referenced this pull request Nov 29, 2023
lukebakken added a commit that referenced this pull request Nov 29, 2023
Pliner reviewed Nov 30, 2023
5098413 to 21ecfb1 Compare lukebakken added a commit that referenced this pull request Nov 30, 2023
Contributor
| LGTM |
Contributor
MarcialRosales left a comment
There was a problem hiding this comment.
Looks good to me . Thanks @lukebakken for taking care of it.
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionFactorywithCredentialsRefreshermakes the second connection fail #1429Fixes #1429