Skip to content

Fix #1429#1431

Merged
lukebakken merged 1 commit intomainfrom
rabbitmq-dotnet-client-1429
Dec 1, 2023
Merged

Fix #1429#1431
lukebakken merged 1 commit intomainfrom
rabbitmq-dotnet-client-1429

Conversation

@lukebakken
Copy link
Collaborator

Fixes #1429

@lukebakken lukebakken added this to the 7.0.0 milestone Nov 29, 2023
@lukebakken lukebakken self-assigned this Nov 29, 2023
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1429 branch from 633b909 to 5098413 Compare November 29, 2023 20:51
@lukebakken lukebakken mentioned this pull request Nov 29, 2023
lukebakken added a commit that referenced this pull request Nov 29, 2023
See #1431 * Modify test program to demonstrate the issue * Fix underlying issue by allowing multiple Register calls for the same instance of ICredentialsProvider
lukebakken added a commit that referenced this pull request Nov 29, 2023
See #1431 * Modify test program to demonstrate the issue * Fix underlying issue by allowing multiple Register calls for the same instance of ICredentialsProvider
* Add test that demonstrates the failure in #1429 * Refactor OAuth2 tests to use Async API * Fix issue by allowing multiple registrations of the same ICredentialsProvider instance
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1429 branch from 5098413 to 21ecfb1 Compare November 30, 2023 16:09
lukebakken added a commit that referenced this pull request Nov 30, 2023
See #1431 * Modify test program to demonstrate the issue * Fix underlying issue by allowing multiple Register calls for the same instance of ICredentialsProvider
@lukebakken lukebakken merged commit 55a33e2 into main Dec 1, 2023
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1429 branch December 1, 2023 21:54
@paulomorgado
Copy link
Contributor

LGTM

Copy link
Contributor

@MarcialRosales MarcialRosales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me . Thanks @lukebakken for taking care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants