Merged
Conversation
Contributor Author
| submodule project needs to be updated also |
lukebakken requested changes Jun 12, 2024
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
Collaborator
There was a problem hiding this comment.
@WeihanLi whatever text editor you are using is removing the UTF-8 BOM from these files, and creating an unnecessary change. Please revert.
Contributor Author
There was a problem hiding this comment.
@lukebakken thanks very much for help, I did not notice this before
projects/Test/Common/Common.csproj Outdated
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
Collaborator
There was a problem hiding this comment.
@WeihanLi whatever text editor you are using is removing the UTF-8 BOM from these files, and creating an unnecessary change. Please revert.
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
Collaborator
There was a problem hiding this comment.
@WeihanLi whatever text editor you are using is removing the UTF-8 BOM from these files, and creating an unnecessary change. Please revert.
Update toxiproxy-netcore submodule Add comments about upgrading, formatting
Contributor Author
| thanks for help |
This was referenced Sep 15, 2025
This was referenced Oct 20, 2025
This was referenced Nov 24, 2025
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use the nuget CPM feature to manage the nuget package versions centrally
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocument