Skip to content

Add upcase_first method #23895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2016
Merged

Add upcase_first method #23895

merged 1 commit into from
Mar 30, 2016

Conversation

@glaucocustodio
Copy link
Contributor

@glaucocustodio glaucocustodio commented Feb 26, 2016

No description provided.

@rails-bot
Copy link

rails-bot commented Feb 26, 2016

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.
@glaucocustodio
Copy link
Contributor Author

glaucocustodio commented Feb 26, 2016

Sorry, I am not used with rebase, I made some mistake when rebasing #23781 then I closed the PR.
@maclover7
Copy link
Contributor

maclover7 commented Feb 26, 2016

per #23781 (comment), r? @fxn
@rails-bot rails-bot assigned fxn and unassigned rafaelfranca Feb 26, 2016
@glaucocustodio
Copy link
Contributor Author

glaucocustodio commented Mar 29, 2016

Any update about this PR? Tests failing seems not to be related with these changes.
@rafaelfranca rafaelfranca merged commit 7047e55 into rails:master Mar 30, 2016
rafaelfranca added a commit that referenced this pull request Mar 30, 2016
@rafaelfranca
Merge pull request #23895 from glaucocustodio/add_upcase_first_method
3be1a75 
Add upcase_first method
@glaucocustodio glaucocustodio deleted the add_upcase_first_method branch May 20, 2016 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activesupport

5 participants

@glaucocustodio @rails-bot @maclover7 @fxn @rafaelfranca