Fix React-PropTypes-to-prop-types for destructured require #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I was using React-PropTypes-to-prop-types to convert files in our repo, and I noticed that this type of construct wouldn't be converted: const { PropTypes } = require('react'); To fix this, I modified a function that handled constructs of the following kind: const { PropTypes } = React; Naming the test fixture was a little hard, since there are other fixtures testing almost the same thing. I decided to use the term "direct" to refer to a destructure done "directly" aimed at a require. 
Contributor
| Very nice! Thanks for adding a test and for making this improvement. :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was using React-PropTypes-to-prop-types to convert files in our repo,
and I noticed that this type of construct wouldn't be converted:
const { PropTypes } = require('react');
To fix this, I modified a function that handled constructs of the
following kind:
const { PropTypes } = React;
Naming the test fixture was a little hard, since there are other
fixtures testing almost the same thing. I decided to use the term
"direct" to refer to a destructure done "directly" aimed at a require.