Skip to content

fix(remove-forward-ref): preserve union and intersection types #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(remove-forward-ref): preserve union and intersection types #339

wants to merge 1 commit into from

Conversation

@iamakulov
Copy link

@iamakulov iamakulov commented Aug 19, 2025

Previously, the codemod would drop union (|) and intersection (&) types from props when transforming forwardRef components, leaving components without proper type annotations:

// Before: const Component = React.forwardRef< HTMLElement, { someProp: boolean } & { anotherProp: number }>( (props, ref) => ... ) // Expected “after”: const Component = ( { ref, ...props }: { someProp: boolean } & { anotherProp: number } & { ref: React.RefObject<HTMLDivElement> }) => ... // Actual “after”: types completely missing: const Component = ( { ref, ...props }) => ...

This PR fixes this, adding proper support for union and intersection types.
@iamakulov @claude
fix(remove-forward-ref): preserve union and intersection types
73afa0a 
Previously, the codemod would drop union (|) and intersection (&) types from props when transforming forwardRef components, leaving components without proper type annotations. Now supports: - Union types: ButtonProps | LinkProps - Intersection types: BaseProps & MetaProps - Complex nested combinations Example transformation: ```typescript // Before React.forwardRef<HTMLElement, BaseProps & MetaProps>((props, ref) => ...) // After ({ ref, ...props }: BaseProps & MetaProps & { ref: React.RefObject<HTMLElement> }) => ... ``` 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
@iamakulov
Copy link
Author

iamakulov commented Aug 19, 2025 •
edited
Loading

(Note: these tests will need to be updated a bit (ref → ref?) if #338 lands.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@iamakulov