Make all types that implements ::num_traits::Zero implement crate::num_traits::Zero #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
for [AtCoder 2023/1 Language Update](https://docs.google.com/spreadsheets/d/1HXyOXt5bKwhKWXruzUvfMFHQtBxfZQ0047W7VVObnXI/edit#gid=408033513&range=I2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR depends on #102 and #105. In addition to the changes applied in the PRs, this PR has a bonus: every type that implements
::num_traits::Zeroimplementscrate::num_traits::Zerotoo. Therefore, if your crate depends onnum_traitsand have a type that implement::num_traits::Zeroand want to use it for Fenwick Tree, you can just use it without suffering. On the other hands, even fi your crate does not depend onnum_traitsbut still want to use your own type for Fenwick Tree, you can manually implementcrate::num_traits::Zero.