Skip to content

Fix explicit_counter_loop FN when loop counter starts at non-zero#16620

Merged
Jarcho merged 1 commit intorust-lang:masterfrom
profetia:issue16612
Feb 23, 2026
Merged

Fix explicit_counter_loop FN when loop counter starts at non-zero#16620
Jarcho merged 1 commit intorust-lang:masterfrom
profetia:issue16612

Conversation

@profetia
Copy link
Member

@profetia profetia commented Feb 23, 2026 •
edited by rustbot
Loading

Closes #16612

Previous implementation hardcoded 0 as loop counter start, this PR lifts that restriction.

changelog: [explicit_counter_loop] fix FN when loop counter starts at non-zero
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 23, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu
@github-actions
Copy link

github-actions bot commented Feb 23, 2026 •
edited
Loading

Lintcheck changes for c234b12

Lint Added Removed Changed
clippy::explicit_counter_loop 1 0 0

This comment will be updated if you push new changes
Jarcho
Jarcho requested changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the two span_lint calls. There's no reason to have them separate.

View changes since this review
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Feb 23, 2026
@profetia
Copy link
Member Author

profetia commented Feb 23, 2026

Updated. Thank you!
@profetia profetia requested a review from Jarcho February 23, 2026 17:45
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Feb 23, 2026
@profetia profetia force-pushed the issue16612 branch 2 times, most recently from c94c3a6 to c234b12 Compare February 23, 2026 17:49
Jarcho
Jarcho approved these changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

View changes since this review
@Jarcho Jarcho added this pull request to the merge queue Feb 23, 2026
Merged via the queue into rust-lang:master with commit df995ed Feb 23, 2026
17 of 19 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@profetia @rustbot @Jarcho