Remove even more box syntax uses from src/test #100194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added T-compiler 
Contributor
| (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum added S-waiting-on-author 
Prior work, notably 6550021 from rust-lang#88316 has removed box syntax from most of the testsuite. However, some tests were left out. This commit removes box_syntax uses from more locations in src/test. Some tests that are very box syntax specific are not being migrated.
Member Author
| Before this PR: After this PR: |
Mark-Simulacrum added S-waiting-on-review 
Member
| @bors r+ rollup |
Collaborator
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 7, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#100019 (Revive suggestions for boxed trait objects instead of impl Trait) - rust-lang#100038 (Document the `no-std` target option in config.toml.example) - rust-lang#100194 (Remove even more box syntax uses from src/test) - rust-lang#100206 (test: skip terminfo parsing in Miri) - rust-lang#100230 (Use start_point instead of next_point to point to elided lifetime amp…) - rust-lang#100244 (Add armv4t-none-eabi take2) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Prior work, notably #88316 has removed box syntax from most of the testsuite.
However, some tests were left out.
This commit removes box_syntax uses from more locations in src/test.
This migrates the tests where
boxis mostly an "implementation detail" and not the primary thing being tested by the test.Furthermore, some tests from the mir-opt test suite are not being migrated.