Ensure sanity of all computed ABIs #117500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot added S-waiting-on-review 
RalfJung force-pushed the aggregate-abi branch 2 times, most recently from 94200f6 to 487853e Compare 
This comment has been minimized.
This comment has been minimized.
RalfJung force-pushed the aggregate-abi branch from 487853e to 937ed6d Compare This comment has been minimized.
This comment has been minimized.
RalfJung force-pushed the aggregate-abi branch from 937ed6d to e2b134d Compare This comment has been minimized.
This comment has been minimized.
Member Author
| Oli is on vacation. |
RalfJung force-pushed the aggregate-abi branch from 7f0545c to 1f5480d Compare RalfJung force-pushed the aggregate-abi branch from 1f5480d to 0865a2e Compare 
Member
| It's better to reroll r? compiler |
davidtwco approved these changes Nov 19, 2023
Member
| @bors r+ |
Collaborator
bors added S-waiting-on-bors bors added S-waiting-on-bors Collaborator
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2023
Ensure sanity of all computed ABIs This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we [have to](rust-lang#117351 (comment)) be able to compute a sane ABI for nonsensical function types like `extern "C" fn(str) -> str`. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument. To achieve this, this re-lands the parts of rust-lang#80594 that got reverted in rust-lang#81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having *every* ABI use the wrong broken default! Cc `@bjorn3` Fixes rust-lang#115845
This comment has been minimized.
This comment has been minimized.
Collaborator
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review Member Author
| Ah, that's annoying... we are currently computing things like the |
Member Author
| Ah no I can easily fix that by changing |
Member Author
| @bors r=davidtwco |
Collaborator
bors added S-waiting-on-bors Collaborator
Member Author
| @bors rollup=iffy |
Collaborator
| ☀️ Test successful - checks-actions |
Collaborator
| Finished benchmarking commit (d19980e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.922s -> 675.906s (-0.30%) |
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
…errors the unadjusted ABI needs to pass aggregates by-value Fixes rust-lang#118124, a regression introduced in rust-lang#117500
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 27, 2023
the unadjusted ABI needs to pass aggregates by-value Fixes rust-lang/rust#118124, a regression introduced in rust-lang/rust#117500
This was referenced May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This moves the ABI sanity assertions from the codegen backend to the ABI computation logic. Sadly, due to past mistakes, we have to be able to compute a sane ABI for nonsensical function types like
extern "C" fn(str) -> str. So to make the sanity check pass we first need to make all ABI adjustment deal with unsized types... and we have no shared infrastructure for those adjustments, so that's a bunch of copy-paste. At least we have assertions failing loudly when one accidentally sets a different mode for an unsized argument.To achieve this, this re-lands the parts of #80594 that got reverted in #81388. To avoid breaking wasm ABI again, that ABI now explicitly opts-in to the (wrong, broken) ABI that we currently keep for backwards compatibility. That's still better than having every ABI use the wrong broken default!
Cc @bjorn3
Fixes #115845