Migrate run-make/c-link-to-rust-dylib to rmake.rs #125808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added A-testsuite 
Collaborator
jieyouxu requested changes May 31, 2024
rustbot added S-waiting-on-author 
GuillaumeGomez force-pushed the migrate-run-make-c-link-to-rust-dylib branch from 8f14111 to 57ca594 Compare jieyouxu approved these changes May 31, 2024
| } | ||
| } | ||
| | ||
| pub fn dynamic_lib_extension() -> &'static str { |
Member
There was a problem hiding this comment.
Not-a-review-comment: I am always paranoid about these extensions, I feel like there's almost always edge cases I'm missing
Member
| Thanks, changes look good, r=me after CI is green |
Member Author
| @bors r=jieyouxu rollup |
Collaborator
bors added S-waiting-on-bors jieyouxu added a commit to jieyouxu/rust that referenced this pull request May 31, 2024
…link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`
Member
| @bors r- |
bors added S-waiting-on-author GuillaumeGomez force-pushed the migrate-run-make-c-link-to-rust-dylib branch from 57ca594 to ef4f8e6 Compare Member Author
| Fixed formatting. |
Member Author
| @bors r=jieyouxu |
Collaborator
bors added S-waiting-on-bors GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 1, 2024
…link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 1, 2024
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#124577 (Stabilize `custom_code_classes_in_docs` feature) - rust-lang#125683 (Rewrite `suspicious-library`, `resolve-rename` and `incr-prev-body-beyond-eof` `run-make` tests in `rmake.rs` format) - rust-lang#125773 (Migrate run make cdylib) - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`) r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez force-pushed the migrate-run-make-c-link-to-rust-dylib branch from ab0fc6e to 32933a6 Compare Member Author
| All libs should now be removed as expected. |
GuillaumeGomez force-pushed the migrate-run-make-c-link-to-rust-dylib branch from 32933a6 to 050ff9c Compare Collaborator
| Some changes occurred in src/tools/compiletest cc @jieyouxu |
GuillaumeGomez force-pushed the migrate-run-make-c-link-to-rust-dylib branch from 050ff9c to 32933a6 Compare Member Author
| @bors r=jieyouxu rollup |
Collaborator
bors added S-waiting-on-bors jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jun 2, 2024
…link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#121062 (Change f32::midpoint to upcast to f64) - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`) - rust-lang#125886 (Migrate run make issue 15460) - rust-lang#125890 (Improve compiletest expected/not found formatting) - rust-lang#125896 (compiletest: fix outdated rmake.rs comment) r? `@ghost` `@rustbot` modify labels: rollup
Member
| Died in #125899 (comment) @bors rollup=iffy r- |
bors added S-waiting-on-author Member
| Wait, this is the other PR, sorry. |
Collaborator
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#121062 (Change f32::midpoint to upcast to f64) - rust-lang#125808 (Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`) - rust-lang#125884 (Implement feature `integer_sign_cast`) - rust-lang#125890 (Improve compiletest expected/not found formatting) - rust-lang#125896 (compiletest: fix outdated rmake.rs comment) - rust-lang#125898 (typo: depending from -> on) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2024
Rollup merge of rust-lang#125808 - GuillaumeGomez:migrate-run-make-c-link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of rust-lang#121876. First commit comes from rust-lang#125773. r? `@jieyouxu`
Member
| @bors r- |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Part of #121876.
First commit comes from #125773.
r? @jieyouxu