Allow a git command for getting the current branch in bootstrap to fail #127919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It can fail when in git is in detached HEAD mode.
rustbot added S-waiting-on-review 
Contributor
| @bors r+ |
Collaborator
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 18, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124881 (Use ThreadId instead of TLS-address in `ReentrantLock`) - rust-lang#127656 (make pub_use_of_private_extern_crate show up in cargo's future breakage reports) - rust-lang#127748 (Use Option's discriminant as its size hint) - rust-lang#127854 (Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent`) - rust-lang#127908 (Update extern linking documentation) - rust-lang#127919 (Allow a git command for getting the current branch in bootstrap to fail) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 18, 2024
Rollup merge of rust-lang#127919 - Kobzol:fix-git-command, r=onur-ozkan Allow a git command for getting the current branch in bootstrap to fail Found by `@lukas-code` [here](rust-lang#127680 (comment)). The bug was introduced in rust-lang#127680 (before, the command was allowed to fail). r? `@onur-ozkan`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Found by @lukas-code here. The bug was introduced in #127680 (before, the command was allowed to fail).
r? @onur-ozkan