Skip to content

Just totally fully deny late-bound consts #128020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2024
Merged

Just totally fully deny late-bound consts #128020

merged 1 commit into from
Jul 22, 2024

Conversation

@compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jul 20, 2024 •
edited
Loading

Kinda don't care about supporting this until we have where clauses on binders. They're super busted and should be reworked in due time, and they are approximately 100% useless until then 😸

Fixes #127970
Fixes #127009

r? @BoxyUwU
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2024
@compiler-errors compiler-errors force-pushed the nlb-no-const branch 2 times, most recently from 0110538 to 0b1fe26 Compare July 20, 2024 23:44
@BoxyUwU
Copy link
Member

BoxyUwU commented Jul 21, 2024

bors-r-plus

@bors rollup
@bors
Copy link
Collaborator

bors commented Jul 21, 2024

📌 Commit 3862095 has been approved by BoxyUwU

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Jul 21, 2024 •
edited
Loading

@bors rollup

Here, you dropped this:

bors-rollup-400px-compressed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#128020 - compiler-errors:nlb-no-const, r=Bo…
4e1ec87 
…xyUwU Just totally fully deny late-bound consts Kinda don't care about supporting this until we have where clauses on binders. They're super busted and should be reworked in due time, and they are approximately 100% useless until then 😸 Fixes rust-lang#127970 Fixes rust-lang#127009 r? `@BoxyUwU`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 21, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2024
@bors
Auto merge of rust-lang#128039 - matthiaskrgr:rollup-jpxahbo, r=matth…
24c72ea 
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#127510 (Rewrite `test-float-parse` in Rust) - rust-lang#127583 (Deal with invalid UTF-8 from `gai_strerror`) - rust-lang#127977 (Update wasi-sdk in CI to latest release) - rust-lang#128014 (Fix stab display in doc blocks) - rust-lang#128020 (Just totally fully deny late-bound consts) - rust-lang#128023 (rustdoc: short descriptions cause word-breaks in tables) - rust-lang#128033 (Explain why we require `_` for empty patterns) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2024
@bors
Auto merge of rust-lang#128039 - matthiaskrgr:rollup-jpxahbo, r=matth…
71690ee 
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#127510 (Rewrite `test-float-parse` in Rust) - rust-lang#127583 (Deal with invalid UTF-8 from `gai_strerror`) - rust-lang#127977 (Update wasi-sdk in CI to latest release) - rust-lang#128014 (Fix stab display in doc blocks) - rust-lang#128020 (Just totally fully deny late-bound consts) - rust-lang#128023 (rustdoc: short descriptions cause word-breaks in tables) - rust-lang#128033 (Explain why we require `_` for empty patterns) r? `@ghost` `@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Jul 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2024
@bors
Auto merge of rust-lang#128048 - workingjubilee:rollup-gehtjxd, r=wor…
ee0fd6c 
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#127583 (Deal with invalid UTF-8 from `gai_strerror`) - rust-lang#128014 (Fix stab display in doc blocks) - rust-lang#128020 (Just totally fully deny late-bound consts) - rust-lang#128023 (rustdoc: short descriptions cause word-breaks in tables) - rust-lang#128033 (Explain why we require `_` for empty patterns) - rust-lang#128038 (Don't output incremental test artifacts into working directory) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 2ef7699 into rust-lang:master Jul 22, 2024
@rustbot rustbot added this to the 1.82.0 milestone Jul 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 22, 2024
@rust-timer
Unrolled build for rust-lang#128020
3890425 
Rollup merge of rust-lang#128020 - compiler-errors:nlb-no-const, r=BoxyUwU Just totally fully deny late-bound consts Kinda don't care about supporting this until we have where clauses on binders. They're super busted and should be reworked in due time, and they are approximately 100% useless until then 😸 Fixes rust-lang#127970 Fixes rust-lang#127009 r? ``@BoxyUwU``
@compiler-errors compiler-errors mentioned this pull request Jul 25, 2024
Merged
@aticu aticu mentioned this pull request Apr 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

5 participants

@compiler-errors @BoxyUwU @bors @jieyouxu @rustbot